Thread (19 messages) 19 messages, 4 authors, 2022-09-28

Re: [PATCH v2] merge-tree: fix segmentation fault in read-only repositories

From: Johannes Schindelin <hidden>
Date: 2022-09-22 17:24:35

Hi Elijah,

just quickly...

On Wed, 21 Sep 2022, Elijah Newren wrote:
On Wed, Sep 21, 2022 at 3:08 PM Johannes Schindelin via GitGitGadget
[off-list ref] wrote:
quoted
@@ -473,7 +475,7 @@ static int real_merge(struct merge_tree_options *o,
                                              &result);
        }
        merge_finalize(&opt, &result);
-       return !result.clean; /* result.clean < 0 handled above */
+       return !result.tree || !result.clean; /* result.clean < 0 handled above */
Thinking out loud, should this logic be at the merge-ort.c level,
You're right, of course. I have pushed up a tentative v3 that does it as
you proposed, and it looks not half bad. I'll look a bit more deeply,
still, but chances are that I'll submit this later today as v3 as-is.

And then I will reply a bit more verbosely, either ;-)

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help