Re: [PATCH v2] Documentation: add ReviewingGuidelines
From: Junio C Hamano <hidden>
Date: 2022-09-19 21:38:13
"Victoria Dye via GitGitGadget" [off-list ref] writes:
From: Victoria Dye <redacted>
Add a reviewing guidelines document including advice and common terminology
used in Git mailing list reviews. The document is included in the
'TECH_DOCS' list in order to include it in Git's published documentation.
Helped-by: Johannes Schindelin [off-list ref]
Helped-by: Derrick Stolee [off-list ref]
Helped-by: Junio C Hamano [off-list ref]
Helped-by: Josh Steadmon [off-list ref]
Signed-off-by: Victoria Dye <redacted>
---
Documentation: add ReviewingGuidelines
This patch follows up on a discussion a few weeks ago in the Git IRC
standup [1], where it was mentioned that it would be nice to have
consistent definitions for common review terminology (like 'nit:'). The
"ReviewingGuidelines" document created here builds on that idea, as well
as past discussions around the idea of advice for reviewers (similar to
the guidelines for new contributors in MyFirstContribution [2]).Thanks. Will queue. I think this is ready for 'next' and then to 'master' during this cycle. Thanks for writing it, and thanks all for reviewing it.