Re: [PATCH v7 5/6] fsmonitor: deal with synthetic firmlinks on macOS
From: Junio C Hamano <hidden>
Date: 2022-09-16 20:15:21
"Eric DeCosta via GitGitGadget" [off-list ref] writes:
Starting with macOS 10.15 (Catalina), Apple introduced a new feature called 'firmlinks' in order to separate the boot volume into two volumes, one read-only and one writable but still present them to the user as a single volume. Along with this change, Apple removed the ... Therefore, in order to deal with synthetic firmlinks, the root directory is scanned and the first possible synthetic firmink that, when resolved, is a prefix of the worktree is used to map FSEvents paths to worktree paths.
The proposed log message for this step seems fairly similar to the previous one.
quoted hunk
diff --git a/fsmonitor--daemon.h b/fsmonitor--daemon.h index e24838f9a86..98cbb430083 100644 --- a/fsmonitor--daemon.h +++ b/fsmonitor--daemon.h@@ -170,5 +170,8 @@ void fsmonitor_publish(struct fsmonitor_daemon_state *state, */ void fsmonitor_force_resync(struct fsmonitor_daemon_state *state); +char *fsmonitor_resolve_alias(const char *path, + struct alias_info *alias); +
After applying all the 6 steps, this function is declared here without any implementation. Should we drop this step, I have to wonder. Thanks.