Thread (1 message) 1 message, 1 author, 2022-09-13

Re: [PATCH v2] chainlint: colorize problem annotations and test delimiters

From: Junio C Hamano <hidden>
Date: 2022-09-13 20:47:04

Jeff King [off-list ref] writes:
On Tue, Sep 13, 2022 at 04:01:47AM +0000, Eric Sunshine via GitGitGadget wrote:
quoted
    Reverse video certainly makes the "?!FOO?!" annotations pop out and draw
    the reader's attention. I find that I don't have a strong preference
    between this version and v1 which merely used bold-red, but I suspect
    that v2 with its reverse video is probably the better approach.
I find this one slightly uglier, but they are equally
attention-grabbing. And as I hope to rarely see them in the first place,
I am fine either way. :)
Yup, I tend to think that reverse red is uglier and is more
attention grabbing than bold red.  Let's stop here for now and let
others paint it in other colors by introducing configuration knob or
whatnot but outside the topic.
Thanks again for adding this.
That too.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help