Re: [PATCH 1/4] list-objects-filter: don't memset after releasing filter struct
From: Junio C Hamano <hidden>
Date: 2022-09-12 15:40:36
Jeff King [off-list ref] writes:
If we see an error while parsing a "combine" filter, we call list_objects_filter_release() to free any allocated memory, and then use memset() to return the struct to a known state. But the release function already does that reinitializing. Doing it again is pointless.
Makes sense.
quoted hunk
Signed-off-by: Jeff King <redacted> --- list-objects-filter-options.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c index 6cc4eb8e1c..ea989db260 100644 --- a/list-objects-filter-options.c +++ b/list-objects-filter-options.c@@ -187,10 +187,8 @@ static int parse_combine_filter( cleanup: strbuf_list_free(subspecs); - if (result) { + if (result) list_objects_filter_release(filter_options); - memset(filter_options, 0, sizeof(*filter_options)); - } return result; }