Thread (1 message) 1 message, 1 author, 2022-09-08

Re: [PATCH v2 4/5] cmake: avoid editing t/test-lib.sh

From: Junio C Hamano <hidden>
Date: 2022-09-08 23:59:01

Victoria Dye [off-list ref] writes:
I don't think it does more harm than good, but I wouldn't go so far as to
call it a definitive "net improvement." I'd personally very much prefer a
solution that didn't involve adding 'GIT-BUILD-DIR' just for the sake of
CMake.
...
... "switching between make & CMake" file staleness (if I'm not mistaken, the
same thing can happen now with the modified 'test-lib.sh', so this patch
doesn't really make anything worse), I do think the changes to 'test-lib.sh'
should be rearranged to preserve the "PANIC" check:
Thanks for a quality review.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help