Thread (6 messages) flat view 6 messages, 2 authors, 2022-09-06

Re: [PATCH 2/2] rev-list: disable commit graph with --verify-objects

From: Taylor Blau <hidden>
Date: 2022-09-06 21:20:48

On Tue, Sep 06, 2022 at 05:04:35PM -0400, Jeff King wrote:
So it seems like the safest thing is to just disable the commit graph
for the whole process when we see the --verify-objects option. We can do
that either in builtin/rev-list.c, where we use the option, or in
revision.c, where we parse it. There are some subtleties:
Agreed that putting it in the rev-list code makes sense.

I was wondering whether disabling the commit graph would survive
a `raw_object_store_clear()` or `close_commit_graph()`. But it does,
since we're not actually touching the `commit_graph` pointer itself, but
a second variable `commit_graph_disabled`, which isn't ever set back to
0.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help