Re: [PATCH v4 2/4] fsmonitor: generate unique Unix socket file name in the desired location

From
Junio C Hamano <hidden>
Date
2022-08-31 20:12:05
"Eric DeCosta via GitGitGadget" [off-list ref] writes:
quoted hunk
+const char *fsmonitor_ipc__get_path(void)
+{
+#ifdef WIN32
+	return fsmonitor_ipc__get_default_path();
+#else
Hmph.

As compat/fsmonitor/ directory already sets up a good way to have
platform-specific implementation of a common API function, I think
this patch goes in a wrong direction by fighting it.

Shouldn't the rest of the function we see here be made to another 
implementation of fsmonitor_ipc__get_default_path() that is
specific to platforms, i.e. in compat/fsmonitor/$somenewfile.c,
that is used for !WIN32 case?
Thread (1 message) 1 message, 1 author, last reply 2022-08-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help