Thread (1 message) 1 message, 1 author, 2022-08-24

Re: [PATCH v2 0/4] built-in add -p: support diff-so-fancy better

From: Junio C Hamano <hidden>
Date: 2022-08-24 22:11:42

"Johannes Schindelin via GitGitGadget" [off-list ref]
writes:
Philippe Blain reported in
https://lore.kernel.org/git/ecf6f5be-22ca-299f-a8f1-bda38e5ca246@gmail.com (local)
that there is a problem when running the built-in version of git add -p with
diff-so-fancy [https://github.com/so-fancy/diff-so-fancy] as diff colorizer.
The symptom is this:

    error: could not parse colored hunk header '?[36m?[1m?[38;5;13m@ file:1 @?[1m?[0m'


This patch series addresses that and should fix
https://github.com/so-fancy/diff-so-fancy/issues/437

Changes since v1:

 * Added a commit to ignore dirty submodules just like the Perl version
   does.
Thanks, all.  Will queue, but it may miss this afternoon's
integration I am preparing right now for pushing out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help