Re: [PATCH v2] promisor-remote: fix xcalloc() argument order

SZEDER Gábor [off-list ref] writes:

On Wed, Aug 24, 2022 at 08:58:21AM -0700, Junio C Hamano wrote:

quoted

SZEDER Gábor [off-list ref] writes:

quoted

Patch generated with:

  make SPATCH_FLAGS=--recursive-includes contrib/coccinelle/xcalloc.cocci.patch

Our default SPATCH_FLAGS ('--all-includes') doesn't catch this
transformation by default, unless used in combination with a large-ish
SPATCH_BATCH_SIZE which happens to put 'promisor-remote.c' with a file
that includes 'repository.h' directly in the same batch.

Our default SPATCH_FLAGS is actually

    SPATCH_FLAGS = --all-includes --patch .

and I am wondering how "--patch ." part (or droppage thereof due to
overriding it from the command line) affects the outcome.

'--patch .' is not part of SPATCH_FLAGS anymore, and for a good
reason, see the recent 7b63ea5750 (Makefile: remove mandatory "spatch"
arguments from SPATCH_FLAGS, 2022-07-05).

Ahh, that makes my life a bit more cumbersome, as I was looking at
how we did things on the 'maint' branch.

Thanks, mystery solved.