Thread (1 message) 1 message, 1 author, 2022-08-18

Re: [PATCH v4 07/11] builtin/diagnose.c: create 'git diagnose' builtin

From: Junio C Hamano <hidden>
Date: 2022-08-18 19:12:32

Ævar Arnfjörð Bjarmason [off-list ref] writes:
On Fri, Aug 12 2022, Victoria Dye via GitGitGadget wrote:
quoted
From: Victoria Dye <redacted>
[...]
This is correct:
quoted
+'git diagnose' [(-o | --output-directory) <path>] [(-s | --suffix) <format>]
...
quoted
+	N_("git diagnose [-o|--output-directory <path>] [-s|--suffix <format>]"),
But this is not, it's missing () around the short v.s. long option, and
we should have a space surrounding the "|" as well.
You are commenting on what appears inside N_() and I agree that it
should match the other one.

It is kind of sad that our usage strings do not allow proper
translation and instead force translaters to _know_ that they are
supposed to touch _only_ the placeholder strings (path and format in
this case).

Not your fault, or Victoria's, of course ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help