Thread (66 messages) 66 messages, 9 authors, 2022-10-19

Re: [PATCH 2/5] rebase: store orig_head as a commit

From: Johannes Schindelin <hidden>
Date: 2022-08-16 10:00:09

Hi Phillip,

On Mon, 15 Aug 2022, Phillip Wood via GitGitGadget wrote:
From: Phillip Wood <redacted>

Using a struct commit rather than a struct oid to hold orig_head means
that we error out straight away if branch being rebased does not point
to a commit. It also simplifies the code than handles finding the
merge base and fork point as it not longer has to convert from an oid
to a commit.
Very nice!

The diff is necessarily "chatty", therefore it is especially good that you
separated out this concern into its own, easily-reviewable commit.

Thank you,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help