Re: [BUG] Unicode filenames handling in `git log --stat`
From: Torsten Bögershausen <hidden>
Date: 2022-08-10 11:42:04
From: Torsten Bögershausen <hidden>
Date: 2022-08-10 11:42:04
On Wed, Aug 10, 2022 at 11:51:58AM +0200, Torsten Bögershausen wrote:
On Wed, Aug 10, 2022 at 12:56:11PM +0400, Alexander Meshcheryakov wrote: Thanks for digging. (And please, try to avoid top-posting here in this list)quoted
I believe I have found exact place where strlen is used incorrectly This is at diff.c:show_stats https://github.com/git/git/blob/c50926e1f48891e2671e1830dbcd2912a4563450/diff.c#L2623 It probably should be replaced with one of utf8_width, utf8_strnwidth or utf8_strwidth from utf8.c
Please forget what I wrote earlier - I was running the wrong `git` binary :-( Sorry for the noise. I can probably do more testing soonish.