Thread (1 message) 1 message, 1 author, 2022-07-21

Re: [PATCH v8] ls-files: introduce "--format" option

From: Junio C Hamano <hidden>
Date: 2022-07-21 17:23:18

Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted
quoted
      +test_expect_success 'git ls-files --format objectmode v.s. -s' '
     -+	git ls-files -s | awk "{print \$1}" >expect &&
     ++	git ls-files -s >files &&
     ++	cut -d" " -f1 files >expect &&
Either "awk" or "cut" is fine and flipping between them is a bit
distracting.  Cutting the pipe into two is a good move.
That "cut" suggestion saw mine, sorry about the churn...
As I said "cut" is perfectly fine.  Unless this part goes away,
(i.e. perhaps we may decide that it is a bad idea to check only the
pieces of lines), let's not flip back to awk ;-)
quoted
	format="%(objectmode) %(objectname) %(stage)	%(path)" &&
	git ls-files -s >expect &&
	git ls-files --format="$format" >actual &&
	test_cmp expect actual

I do not know if the $format I wrote without looking at the doc is
correct, but you get the idea.
Past rounds moved some tests towards that, maybe that's a good thing
here too I didn't look deeply this time around...
OK, thanks for reviewing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help