Thread (1 message) 1 message, 1 author, 2022-07-18

Re: [PATCH v2] git-p4: fix bug with encoding of p4 client name

From: Junio C Hamano <hidden>
Date: 2022-07-18 16:38:06

"Kilian Kilger via GitGitGadget" [off-list ref] writes:
From: Kilian Kilger <redacted>

The Perforce client name can contain arbitrary characters
which do not decode to UTF-8. Use the fallback strategy
implemented in metadata_stream_to_writable_bytes() also
for the client name.

Signed-off-by: Kilian Kilger <redacted>
---
    git-p4: Fix bug with encoding of P4 client name
Sorry, is this to improve the topic that has already last Monday?

If so, it is way too late to update with a replacement patch, like
this.  Instead, please send in a follow-up patch on top of what has
already been merged.

The description above seems to be identical to what was in the
previous round, but the patch seems to use a lot more code, so
such a follow-up patch would have plenty to explain how the new
strategy improves over the previous one.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help