Thread (1 message) 1 message, 1 author, 2022-07-14

Re: [PATCH] hooks--pre-commit: detect non-ASCII when renaming

From: Junio C Hamano <hidden>
Date: 2022-07-14 23:08:24

Junio C Hamano [off-list ref] writes:
"Julian Prein via GitGitGadget" [off-list ref] writes:
quoted
From: Julian Prein <redacted>

Currently the diff-filter that is used to check for non-ASCII characters
in filenames only checks new additions.

Extend the diff-filter in the pre-commit sample to include `CR` as well.
This way non-ASCII character in filenames are detected on a rename/copy
as well.
It would probably be a better implementation to disable the rename
detection, instead of adding Copies and Renames.
That is ...
quoted
-	test $(git diff --cached --name-only --diff-filter=A -z $against |
... instead of using the "git diff" Porcelain, we can probably use
the "git diff-index" plumbing command here, which will not be
affected by end-user configuration or by the fact that recent "git
diff" turns on the rename detection by default.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help