Re: [PATCH v2 1/4] revision: improve commit_rewrite_person()
From: Junio C Hamano <hidden>
Date: 2022-07-07 21:52:48
Siddharth Asthana [off-list ref] writes:
quoted hunk
@@ -3835,8 +3859,8 @@ static int commit_match(struct commit *commit, struct rev_info *opt) if (!buf.len) strbuf_addstr(&buf, message); - commit_rewrite_person(&buf, "\nauthor ", opt->mailmap); - commit_rewrite_person(&buf, "\ncommitter ", opt->mailmap); + const char *commit_headers[] = { "author ", "committer ", NULL };
This is decl-after-statement our codebase avoids.
+ commit_rewrite_person(&buf, commit_headers, opt->mailmap); } /* Append "fake" message parts as needed */