Thread (86 messages) 86 messages, 5 authors, 2022-07-01

Re: [PATCH v4 6/7] mv: use flags mode for update_mode

From: Derrick Stolee <hidden>
Date: 2022-06-23 15:11:03

On 6/23/2022 7:41 AM, Shaoxuan Yuan wrote:
As suggested by Derrick [1],
move the in-line definition of "enum update_mode" to the top
of the file and make it use "flags" mode (each state is a different
bit in the word).
nit: strange line-wrapping here.
Change the flag assignments from '=' (single assignment) to '|='
(additive). Also change flag evaluation from '==' to '&', etc.
Code looks good.

Thanks,
-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help