Thread (1 message) 1 message, 1 author, 2022-06-22

Re: [PATCH 10/10] fetch tests: fix needless and buggy re-quoting

From: Junio C Hamano <hidden>
Date: 2022-06-22 15:44:53

Derrick Stolee [off-list ref] writes:
It seems like this isn't the last time we are going to have a
problem with string replacement like this, and having a well-defined
helper would go far.
I think the idea of [10/10] is to use shell itself as a well-defined
helper, with "string replacement" being "$variable_interpolation".

Which isn't a bad approach, I would say.
The rest of the changes to the test script seem more complicated
than necessary for what _should_ be a simple problem.
True.  I am not sure which parts are unnecessary "churn while at it,
burying the most interesting and beneficial one at the end as a
hostage", and which ones are absolutely needed to reach [10/10].
Perhaps all of them are the latter?  I dunno.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help