Thread (3 messages) 3 messages, 2 authors, 2022-06-16

Re: [PATCH 11/11] bug_fl(): add missing `va_end()` call

flat view

From: Junio C Hamano <hidden>
Date: 2022-06-16 18:03:32

Possibly related (same subject, not in this thread)

Ævar Arnfjörð Bjarmason [off-list ref] writes:
But obviously that's a bad use of the varargs API, I just don't know how
we've been getting away with it in practice, sorry about that.
Exactly.  We three all expressed our surprises on why it "works".
Nobody offered an explanation, though, which leaves us in suspense
;-)
The fix Peff's got here LGTM. I can (re)submit it with
format-patch+send-email after giving it a commit message describing the
issue if you'd like, but the change would be the same.
Yup, I think the code change there looks the most sensible.

Thanks, all.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help