Re: [PATCH] t3701: two subtests are fixed

Michael J Gruber [off-list ref] writes:

Johannes Schindelin venit, vidit, dixit 2022-06-15 16:50:40:

quoted

Hi Michael,

Hallo Dscho!

quoted

On Tue, 14 Jun 2022, Michael J Gruber wrote:

quoted

0527ccb1b5 ("add -i: default to the built-in implementation", 2021-11-30)
switched to the implementation which fixed to subtest. Mark them as
expect_success now.

Good catch!

 
I'm no list regular anymore, but still a "next+ regular". While
experimenting with my own patch I noticed something got fixed
unexpectedly. That goes to show that these unexpected successes
(from expect_failure) go unnoticed too easily. I had missed this on my
regular rebuilds.

Thanks for being a "next+ regular".  They are giving us a valuable
service to catch bugs and questionable design decisions before they
hit the "master" branch.

Ævar noticed this and has a better version of my patch, I think.

Yup.  Eventually we will make it even impossible to opt out of the
built-in variant, but until then, we'd need the conditional stuff.

Thanks.