Re: [PATCH 10/11] relative_url(): fix incorrect condition
From: Junio C Hamano <hidden>
Date: 2022-06-16 05:02:39
"Johannes Schindelin via GitGitGadget" [off-list ref] writes:
From: Johannes Schindelin <redacted> In 63e95beb085c (submodule: port resolve_relative_url from shell to C, 2016-04-15), we added a loop over `url` where we are looking for `../` or `./` components. The loop condition we used is the pointer `url` itself, which is clearly not what we wanted.
8/11, 9/11, and 10/11 are trivially correct. Will queue. Thanks.
quoted hunk
Pointed out by Coverity. Signed-off-by: Johannes Schindelin <redacted> --- remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/remote.c b/remote.c index 9b9bbfe80ec..bded6acbfe8 100644 --- a/remote.c +++ b/remote.c@@ -2846,7 +2846,7 @@ char *relative_url(const char *remote_url, const char *url, * When the url starts with '../', remove that and the * last directory in remoteurl. */ - while (url) { + while (*url) { if (starts_with_dot_dot_slash_native(url)) { url += 3; colonsep |= chop_last_dir(&remoteurl, is_relative);