Thread (1 message) 1 message, 1 author, 2022-06-08

Re: [PATCH v13 5/7] object-file.c: add "stream_loose_object()" to handle large object

From: Junio C Hamano <hidden>
Date: 2022-06-08 15:35:32

Neeraj Singh [off-list ref] writes:
quoted
Still, we need to save the temporary file we're preparing
somewhere. We'll do that in the top-level ".git/objects/"
directory (or whatever "GIT_OBJECT_DIRECTORY" is set to). Once we've
streamed it we'll know the OID, and will move it to its canonical
path.
I think this new logic doesn't play well with batched-fsync. Even
through we don't know the final OID, we should still call 
prepare_loose_object_bulk_checkin to potentially create the bulk
checkin objdir.
Good point.  Careful sanity checks like this are very much
appreciated.
Thanks for including me on the review!
Yes, indeed.

Thanks, both.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help