Thread (1 message) 1 message, 1 author, 2022-06-03

Re: [PATCH v3] git-prompt: make colourization consistent

From: Junio C Hamano <hidden>
Date: 2022-06-03 20:50:12

Joakim Petersen [off-list ref] writes:
That does seem like a much better idea for maintainability, I can
change the patch to do this instead. I have one question, though: the
sequence $c$b (bare state and branch name) is a special case, where
they're intended to have the same colour, should I wrap both in colour
set, colour clear, or only clear after $b?
If we want to allow $c and $b appear in different places (which I
have no opinion on), I would say we should just color them
independently and fix the test that expects the close linkage
between the two.  I offhand see no reason that they _must_ stay
together myself, though.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help