Re: [PATCH] gitweb: switch to a modern DOCTYPE
From: Junio C Hamano <hidden>
Date: 2022-06-02 06:11:01
"brian m. carlson" [off-list ref] writes:
quoted
While that DOCTYPE is still valid [2], it has several disadvantages: 1. It’s misleading. The DTD that browsers are supposed to use with that DOCTYPE has nothing to do with XHTML 1.0 and isn’t available at the URL that is given [2].While the WHATWG may claim that, an XML parser is absolutely within its rights to refer to and use that DTD, and in fact should do so unless its catalog directs it elsewhere. It may be that some browsers use an internal catalog that refers to a different DTD, however.quoted
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 606b50104c..1835487ab2 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -4219,7 +4219,10 @@ sub git_header_html { my $mod_perl_version = $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : ''; print <<EOF; <?xml version="1.0" encoding="utf-8"?> -<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<!DOCTYPE html [ + <!ENTITY nbsp " "> + <!ENTITY sdot "⋅"> +]>I think this should be fine. It defines the entities we need and appears to be valid XML. I don't think there should be any problem upgrading to XHTML 5 here.
OK, so in short, the patch text looks OK and the proposed log message needs a bit more work? Thanks.