Re: [PATCH v3 6/9] po/git.pot: don't check in result of "make pot"

On Mon, May 23, 2022 at 4:30 PM Jiang Xin [off-list ref] wrote:

On Mon, May 23, 2022 at 3:27 PM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

quoted

On Mon, May 23 2022, Jiang Xin wrote:

quoted

 .PHONY: pot
 pot: po/git.pot

@@ -3319,6 +3319,7 @@ dist-doc: git$X

 distclean: clean
      $(RM) configure
+     $(RM) po/git.pot

I think I noted "why not add this to clean?" in an earlier round, but
didn't think it through.

On second thought we should do that, but the reason is that "distclean"
should only clean things that you get if you do "make dist".

I.e. we add "configure" to a generated tarball, but not po/git.pot, so
this should just be under regular "clean", not "distclean".

Will remove "po/git.pot" under regular "clean" rule in next reroll. I
copied it from your original patch without thinking carefully.

Like this:

-- snip --

diff --git a/Makefile b/Makefile
index 3122672263..161ebf4ff3 100644
--- a/Makefile
+++ b/Makefile

@@ -3319,7 +3319,6 @@ dist-doc: git$X

 distclean: clean
        $(RM) configure
-       $(RM) po/git.pot
        $(RM) config.log config.status config.cache
        $(RM) config.mak.autogen config.mak.append
        $(RM) -r autom4te.cache

@@ -3333,6 +3332,7 @@ cocciclean:

 clean: profile-clean coverage-clean cocciclean
        $(RM) -r .build
+       $(RM) po/git.pot
        $(RM) *.res
        $(RM) $(OBJECTS)
        $(RM) $(LIB_FILE) $(XDIFF_LIB) $(REFTABLE_LIB) $(REFTABLE_TEST_LIB)
-- snap --