Re: [PATCH v4 12/17] builtin/repack.c: support generating a cruft pack

On Thu, May 19, 2022 at 01:29:26PM +0200, Ævar Arnfjörð Bjarmason wrote:

On Wed, May 18 2022, Taylor Blau wrote:

quoted

+		tip="$(git rev-parse cruft)" &&

Here we don't hide the exit status of "git", as it'll be reflected in what's &&-chained.

Oops! Nice catch.

quoted

+		path="$objdir/$(test_oid_to_path "$(git rev-parse cruft)")" &&

But here we do, as we'll get the exit status of test_oid_to_path. But as
we just rev parsed it shouldn't this be $tip in any case?

Indeed, this can just be:

    path="$objdir/$(test_oid_to_path "$tip")" &&

Will include in a reroll shortly.

Thanks,
Taylor