Thread (1 message) 1 message, 1 author, 2022-05-20

Re: [PATCH v2 04/10] sparse-index: introduce partially-sparse indexes

From: Junio C Hamano <hidden>
Date: 2022-05-20 18:24:00

Derrick Stolee [off-list ref] writes:
quoted
Also these names being in cache.h and visible everywhere is somewhat
worrying.  Other CPP macros and enum constants in the file have
names that are prepared to be truly global, but COMPLETELY_FULL and
COLLAPSED do not hint that they are about sparse-index state as
strongly as PARTIALLY_SPARSE does.
Would prepending with "INDEX_" be sufficient?
Yeah, index-collapsed, index-expanded, etc., sounds distinctive
enough.  Sorry, but I cannot think of a good phrase for partially
expanded case that is short, succinct and would go well with the
fully expanded and fully collapsed cases.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help