Thread (6 messages) 6 messages, 5 authors, 2022-05-20

Re: What's cooking in git.git (May 2022, #05; Mon, 16)

flat view

From: Carlo Marcelo Arenas Belón <hidden>
Date: 2022-05-19 15:23:58

On Mon, May 16, 2022 at 10:37:04PM -0700, Junio C Hamano wrote:
* cb/path-owner-check-with-sudo (2022-05-12) 4 commits
 - git-compat-util: allow root to access both SUDO_UID and root owned
 - t0034: add negative tests and allow git init to mostly work under sudo
 - git-compat-util: avoid failing dir ownership checks if running privileged
 - t: regression git needs safe.directory when using sudo

 With a recent update to refuse access to repositories of other
 people by default, "sudo make install" and "sudo git describe"
 stopped working.  This series intends to loosen it while keeping
 the safety.

 Will merge to 'next'?
 source: [ref]
I am obviously biased, and probably confused, since this is already in the
"cooking" section, but I think this is ready and should be merged to next
without the optional patch 4.

That MIGHT helps us understand how bad of a regression it is in the real
world for not being able to access a repository owned by root by a root
user that got there by doing `sudo -s` and then browsing around (which IMHO
we shouldn't be encouraging people to do, anyway).

and if there is an outcry, it will be easily "fixed" by getting patch 4 in,
which ironically might had been the only patch almost no one commented on so
far, but I think is less likely to have issues that might need to be fixed
before doing so.

Carlo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help