Re: [PATCH 1/8] sparse-index: create expand_to_pattern_list()

[PATCH 0/8] Sparse index: integrate with sparse-checkout · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
[PATCH 1/8] sparse-index: create expand_to_pattern_list() · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
Re: [PATCH 1/8] sparse-index: create expand_to_pattern_list() · Victoria Dye <hidden> · 2022-05-16
Re: [PATCH 1/8] sparse-index: create expand_to_pattern_list() · Derrick Stolee <hidden> · 2022-05-16
[PATCH 4/8] sparse-checkout: --no-sparse-index needs a full index · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
[PATCH 2/8] sparse-index: introduce partially-sparse indexes · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
[PATCH 6/8] sparse-index: complete partial expansion · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
Re: [PATCH 6/8] sparse-index: complete partial expansion · Victoria Dye <hidden> · 2022-05-16
Re: [PATCH 6/8] sparse-index: complete partial expansion · Derrick Stolee <hidden> · 2022-05-17
[PATCH 7/8] p2000: add test for 'git sparse-checkout [add|set]' · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
[PATCH 5/8] sparse-index: partially expand directories · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
Re: [PATCH 5/8] sparse-index: partially expand directories · Victoria Dye <hidden> · 2022-05-16
[PATCH 3/8] cache-tree: implement cache_tree_find_path() · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
[PATCH 8/8] sparse-checkout: integrate with sparse index · Derrick Stolee via GitGitGadget <hidden> · 2022-05-16
Re: [PATCH 8/8] sparse-checkout: integrate with sparse index · Victoria Dye <hidden> · 2022-05-16
Re: [PATCH 8/8] sparse-checkout: integrate with sparse index · Derrick Stolee <hidden> · 2022-05-17
[PATCH v2 00/10] Sparse index: integrate with sparse-checkout · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 02/10] t1092: stress test 'git sparse-checkout set' · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 03/10] sparse-index: create expand_to_pattern_list() · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 04/10] sparse-index: introduce partially-sparse indexes · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 01/10] t1092: refactor 'sparse-index contents' test · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 05/10] cache-tree: implement cache_tree_find_path() · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 07/10] sparse-index: partially expand directories · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 06/10] sparse-checkout: --no-sparse-index needs a full index · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 09/10] p2000: add test for 'git sparse-checkout [add|set]' · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 10/10] sparse-checkout: integrate with sparse index · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
[PATCH v2 08/10] sparse-index: complete partial expansion · Derrick Stolee via GitGitGadget <hidden> · 2022-05-19
Re: [PATCH v2 08/10] sparse-index: complete partial expansion · Junio C Hamano <hidden> · 2022-05-21
Re: [PATCH v2 08/10] sparse-index: complete partial expansion · Derrick Stolee <hidden> · 2022-05-23
Re: [PATCH v2 08/10] sparse-index: complete partial expansion · Derrick Stolee <hidden> · 2022-05-23
Re: [PATCH v2 08/10] sparse-index: complete partial expansion · Junio C Hamano <hidden> · 2022-05-23
Re: [PATCH v2 08/10] sparse-index: complete partial expansion · Derrick Stolee <hidden> · 2022-05-25
[PATCH v3 00/10] Sparse index: integrate with sparse-checkout · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 01/10] t1092: refactor 'sparse-index contents' test · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 04/10] sparse-index: introduce partially-sparse indexes · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 03/10] sparse-index: create expand_index() · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 02/10] t1092: stress test 'git sparse-checkout set' · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 05/10] cache-tree: implement cache_tree_find_path() · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 07/10] sparse-index: partially expand directories · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 06/10] sparse-checkout: --no-sparse-index needs a full index · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 09/10] p2000: add test for 'git sparse-checkout [add|set]' · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 08/10] sparse-index: complete partial expansion · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23
[PATCH v3 10/10] sparse-checkout: integrate with sparse index · Derrick Stolee via GitGitGadget <hidden> · 2022-05-23

From: Derrick Stolee <hidden>
Date: 2022-05-16 21:08:27

On 5/16/2022 4:36 PM, Victoria Dye wrote:

Derrick Stolee via GitGitGadget wrote:

quoted

-void ensure_full_index(struct index_state *istate)
+void expand_to_pattern_list(struct index_state *istate,
+			      struct pattern_list *pl)

Hyper-nit: I don't think this is aligned (it's probably not worth fixing
unless you end up rerolling for something else).

You're right. When I saw this I thought it was just the
"off by one" issue when patches have a "+" in the beginning,
but it's actually the backwards order. Thanks for catching it.

-Stolee

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help