Re: [PATCH v2 2/2] test-lib-functions: fix test_subcommand_inexact
From: Taylor Blau <hidden>
Date: 2022-03-24 18:49:45
On Thu, Mar 24, 2022 at 06:34:57PM +0000, Derrick Stolee via GitGitGadget wrote:
All existing tests continue to pass with this change. There was one instance from t7700-repack.sh that was taking advantage of this flexibility, but it was removed in the previous change.
In my tree, the test modified by the previous patch was the only caller
of `test_subcommand_inexact()`. Looking through the output of:
git for-each-ref refs/remotes/origin/ --format='%(refname)' | xargs -L1 \
git -P grep -l test_subcommand_inexact -- t | sort -u
it doesn't look like there are any other topics in flight [1] that call
test_subcommand_inexact(), either.
Unless you have any pending series which want to call
test_subcommand_inexact, I'd be just as happy to get rid of the function
entirely.
Thanks,
Taylor
[1]: My `origin` points to Junio's tree, so I'm looking through all of
the topic branches before integration, not just the standard "master",
"next", etc.