Re: [PATCH v2 2/7] core.fsyncmethod: batched disk flushes for loose-objects
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2022-03-23 13:27:43
On Sun, Mar 20 2022, Neeraj Singh via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
From: Neeraj Singh <redacted> [..diff --git a/Documentation/config/core.txt b/Documentation/config/core.txt index 889522956e4..a3798dfc334 100644 --- a/Documentation/config/core.txt +++ b/Documentation/config/core.txt@@ -628,6 +628,13 @@ core.fsyncMethod:: * `writeout-only` issues pagecache writeback requests, but depending on the filesystem and storage hardware, data added to the repository may not be durable in the event of a system crash. This is the default mode on macOS. +* `batch` enables a mode that uses writeout-only flushes to stage multiple + updates in the disk writeback cache and then does a single full fsync of + a dummy file to trigger the disk cache flush at the end of the operation.
I think adding a \n\n here would help make this more readable & break the flow a bit. I.e. just add a "+" on its own line, followed by "Currently...
quoted hunk ↗ jump to hunk
+ Currently `batch` mode only applies to loose-object files. Other repository + data is made durable as if `fsync` was specified. This mode is expected to + be as safe as `fsync` on macOS for repos stored on HFS+ or APFS filesystems + and on Windows for repos stored on NTFS or ReFS filesystems.