Thread (1 message) 1 message, 1 author, 2022-03-17

Re: [PATCH 4/5] packed-backend: remove stub BUG(...) functions

From: Junio C Hamano <hidden>
Date: 2022-03-17 17:40:11

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
-	.for_each_reflog_ent = packed_for_each_reflog_ent,
-	.for_each_reflog_ent_reverse = packed_for_each_reflog_ent_reverse,
-	.reflog_exists = packed_reflog_exists,
-	.create_reflog = packed_create_reflog,
-	.delete_reflog = packed_delete_reflog,
-	.reflog_expire = packed_reflog_expire
+	.for_each_reflog_ent = NULL,
+	.for_each_reflog_ent_reverse = NULL,
+	.reflog_exists = NULL,
+	.create_reflog = NULL,
+	.delete_reflog = NULL,
+	.reflog_expire = NULL,
Yup, the entry in vtable being set to NULL is a more direct sign the
readers would appreciate than a name natural for the method, whose
definition needs to be consulted before the readers can realize that
it is a "missing" method.

Very sensible.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help