Thread (45 messages) 45 messages, 6 authors, 2022-04-08

Re: [PATCH 10/25] bundle: add --filter option to 'fetch'

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2022-03-11 13:45:44

On Wed, Feb 23 2022, Derrick Stolee via GitGitGadget wrote:
From: Derrick Stolee <redacted>
[...]
+			/* Skip if filter does not match. */
+			if (!filter && info->filter_str)
+				continue;
+			if (filter &&
+			    (!info->filter_str || strcasecmp(filter, info->filter_str)))
+				continue;
General API comment: Do we have a need for strcasecmp() now anywhere
when dealing with filters?

    $ git clone --no-checkout --filter=BlOb:nOnE https://github.com/git/git
    fatal: invalid filter-spec 'BlOb:nOnE'
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help