Thread (1 message) 1 message, 1 author, 2022-03-10

Re: [PATCH v2 0/4] builtin add -p: hopefully final readkey fixes

From: Junio C Hamano <hidden>
Date: 2022-03-10 18:53:54

Phillip Wood [off-list ref] writes:
Looking more closely that should be "break" not "return 0". I think
what has happened is that I accidentally based these on an old version
of pw/single-key-interactive which did not contain 24d7ce383a
("terminal: always reset terminal when reading without echo",
2022-02-22)
I thought the base pw/single-key-interactive topic is solid enough
and ready for 'next'?  It probably is a good idea to rebase these
follow-on patches on top of a merge of the base topic into 'master'.

I'll keep v2 in 'seen' but mark the topic as "Expecting a reroll"
in the draft of the next issue of the "What's cooking" report.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help