Thread (5 messages) 5 messages, 5 authors, 2022-03-09

Re: [PATCH] name-rev: test showing failure with non-monotonic commit dates

From: Johannes Schindelin <hidden>
Date: 2022-03-09 21:56:53

Possibly related (same subject, not in this thread)

Hi Junio,

On Mon, 14 Feb 2022, Junio C Hamano wrote:
Jacob Keller [off-list ref] writes:
quoted
From: Jacob Keller <redacted>

If a commit in a sequence of linear history has a non-monotonically
increasing commit timestamp, git name-rev will not properly name the
commit.

However, if you use --annotate-stdin then the commit does actually get
picked up and named properly.
IIRC, this is to be expected.

When preparing to answer --annotate-stdin request, the command has
to dig down to the root of the history, which would be too expensive
in some repositories and wants to stop traversal early when it knows
particular commits it needs to describe.

Dscho?  I think this is pretty much a fundamental part of the
initial version added by bd321bcc (Add git-name-rev, 2005-10-26) and
kept that way to this day, I think.
Yes, it was.

Looks like Stolee had great suggestions while I did not find time to catch
up with the mailing list.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help