Re: [PATCH 2/9] sparse-checkout: make --cone the default
From: Derrick Stolee <hidden>
Date: 2022-03-08 14:26:51
On 3/8/2022 2:39 AM, Elijah Newren via GitGitGadget wrote:
From: Elijah Newren <redacted> Make cone mode the default, and update the documentation accordingly.
Doc changes look good.
quoted hunk ↗ jump to hunk
--- a/builtin/sparse-checkout.c +++ b/builtin/sparse-checkout.c@@ -397,7 +397,7 @@ static int update_modes(int *cone_mode, int *sparse_index) /* Set cone/non-cone mode appropriately */ core_apply_sparse_checkout = 1; - if (*cone_mode == 1) { + if (*cone_mode == 1 || *cone_mode == -1) {
Part of me likes the fact that you're pointing out "if it is
enabled directly or not set at all", but maybe it would be
best to do
if (*cone_mode) {
What do you think?
Thanks,
-Stolee