Thread (2 messages) 2 messages, 2 authors, 2022-03-09

Re: [PATCH 0/9] ci: make Git's GitHub workflow output much more helpful

From: Junio C Hamano <hidden>
Date: 2022-03-07 17:11:50

Possibly related (same subject, not in this thread)

Johannes Schindelin [off-list ref] writes:
quoted
One thing I forgot to mention was that when you expand a failing test it shows
the test script twice before the output e.g.

Error: failed: t7527.35 Matrix[uc:false][fsm:true] enable fsmonitor
failure: t7527.35 Matrix[uc:false][fsm:true] enable fsmonitor
  				git config core.fsmonitor true &&
  				git fsmonitor--daemon start &&
  				git update-index --fsmonitor

  expecting success of 7527.35 'Matrix[uc:false][fsm:true] enable fsmonitor':
  				git config core.fsmonitor true &&
  				git fsmonitor--daemon start &&
  				git update-index --fsmonitor

 ++ git config core.fsmonitor true
 ++ git fsmonitor--daemon start
 ...

I don't know how easy it would be to fix that so that we only show "expecting
success of ..." without the test being printed first
It's not _super_ easy: right now, the patch series does not touch the code
In other words, it is not a new issue introduced by this series, right?
The easiest workaround would probably to add a flag that suppresses the
header `expecting success` in case we're running with the
`--github-workflow-markup` option.
If that is the case, let's leave it outside the series.

If we do not have to hide the solution behind any option specific to
"--github-workflow-markup", then even users (like me) who reguarly
run "cd t && sh ./t1234-a-particular-test.sh -i -v" would benefit if
we no longer have to look at the duplicated test script in the
output.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help