Thread (37 messages) 37 messages, 2 authors, 2022-03-17

Re: [PATCH 10/10] tests: change "cat && chmod +x" to use "test_hook"

From: Eric Sunshine <hidden>
Date: 2022-03-03 05:48:46

On Wed, Mar 2, 2022 at 8:22 AM Ævar Arnfjörð Bjarmason [off-list ref] wrote:
Refactor various test code to use the "test_hook" helper. This change:

 - Fixes the long-standing issues with those tests using "#!/bin/sh"
   instead of "#!$SHELL_PATH". Using "#!/bin/sh" here happened to work
   because this code was so simply that it e.g. worked on Solaris
   /bin/sh.
s/simply/simple/
 - Removes the "mkdir .git/hooks" invocation, as explained in a
   preceding commit we'll rely on the default templates to create that
   directory for us.

For the test in "t5402-post-merge-hook.sh" it's easier and more
correct to unroll the for-loop into a test_expect_success, so let's do
that.

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help