Thread (1 message) 1 message, 1 author, 2022-03-02

Re: [PATCH 05/10] tests: indent and add hook setup to "test_expect_success"

From: Junio C Hamano <hidden>
Date: 2022-03-02 21:27:15

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
Indent various hook setup code in the test suite that's using a manual
"cat && chmod" pattern.

These should also consistently use "#!$SHELL_PATH" instead of
"#!/bin/sh", i.e. "test_script". Let's fix that in a subsequent
commit, which will be easier to review after this smaller change.
These do move them in the right direction, but I am not sure if a
step-wise "first we do <<- trick to kill unindented mess, and then
another "use write_script" to touch the same places, consuming twice
the reviewer bandwidth.  I certainly would hate to have to see these
lines twice X-<.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help