Thread (44 messages) 44 messages, 4 authors, 2022-03-13

Re: [PATCH] userdiff: Add diff driver for Kotlin lang and tests

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2022-03-01 09:38:51

On Tue, Mar 01 2022, Jaydeep P Das wrote:
The xfuncname pattern finds func/class declarations
in diffs to display as a hunk header.

This patch adds xfuncname regex and some respective
tests for Kotlin language.

Also modifies `Documentation./gitattributes.txt` to state
the same.

Signed-off-by: Jaydeep P Das <redacted>
---
 Documentation/gitattributes.txt | 2 ++
 t/t4018/kotlin-class            | 5 +++++
 t/t4018/kotlin-enum-class       | 5 +++++
 t/t4018/kotlin-fun              | 5 +++++
 t/t4018/kotlin-inheritace-class | 5 +++++
 t/t4018/kotlin-inline-class     | 5 +++++
 t/t4018/kotlin-interface        | 5 +++++
 t/t4018/kotlin-nested-fun       | 9 +++++++++
 t/t4018/kotlin-public-class     | 5 +++++
 t/t4018/kotlin-sealed-class     | 5 +++++
 userdiff.c                      | 8 ++++++++
I didn't look at the regexes etc. at a glance, but this is missing the
corresponding tests for the word-diff part of the regexes. It would be
nice to have those tests too.

See the t/t4034/ directory for that (and no, this whole setup isn't very
discoverable, sorry!).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help