Re: [PATCH 0/2] Reduce explicit sleep calls in t7063 untracked cache tests
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2022-02-28 11:04:43
On Mon, Feb 28 2022, Tao Klerks via GitGitGadget wrote:
As noted in a recent proposed patch to t/t7519-status-fsmonitor.sh, a number of test cases in t\t7063-status-untracked-cache.sh explicitly sleep a second, in order to avoid the untracked cache content being invalidated by an mtime race condition. Even though it's only 9 seconds of sleeping that can be straightforwardly replaced, it seems worth fixing if possible. Replace sleep calls with backdating of filesystem changes, but first fix the test-tool chmtime functionality to work for directories in Windows.
Thanks, it will be nice to have that test run a bit faster in wallclock terms.
I do have a question to the list here: Do mingw.c changes need to be upstreamed somewhere? I don't understand the exact relationship between this file and the MinGW project.
No, it's 100% ours. We just put (somewhat inconsistently in some cases) our own code that is only needed for "compat" with some "platforms" into compat/*. Well, somewhat/mostly, then "contrib/" is supposed to be third-party imports, but some code in both is 100% ours, some is out-of-tree, some is effectively perma-forked and has no "upstream" anymore etc.