Thread (1 message) 1 message, 1 author, 2022-02-24

Re: [PATCH v3 3/4] test-lib: make $GIT_BUILD_DIR an absolute path

From: Junio C Hamano <hidden>
Date: 2022-02-24 20:05:30

Ævar Arnfjörð Bjarmason [off-list ref] writes:
So you're OK with the assumption/method being used here, but would
prefer if we also added an explicit check/"exit 1"? E.g.:
	
	if test "$TEST_DIRECTORY" = "${TEST_DIRECTORY%/t}"
	then
	        echo "PANIC: Running in a $TEST_DIRECTORY that doesn't end in '/t'?" >&2
	        exit 1
	fi
Exactly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help