On Fri, Jan 14 2022, Elijah Newren via GitGitGadget wrote:

From: Elijah Newren <redacted>
[...]
+	test_path_is_file init.t &&
+	grep -q dirty init.t
[...]
+	test_path_is_file init.t &&
+	grep -q dirty init.t

Maybe I'm missing something, but can these two just be:

    grep dirty init.t

I.e. won't grep report errors appropriately here, e.g.:
    
    $ grep foo t
    grep: t: Is a directory
    $ grep foo x
    grep: x: No such file or directory

The only prior art I could find was the same pattern in your c449947a79d
(directory rename detection: files/directories in the way of some
renames, 2018-04-19).

It's probably good to lose the "-q" too, unless this output is way too
verbose without it. In any case the errors wouldn't be affected.