Thread (327 messages) 327 messages, 8 authors, 2022-06-02
STALE1471d

[PATCH 11/23] unpack-trees: initialize fsmonitor_has_run_once in o->result

From: Jeff Hostetler via GitGitGadget <hidden>
Date: 2022-02-15 16:00:23
Subsystem: the rest · Maintainer: Linus Torvalds

From: Jeff Hostetler <redacted>

Initialize `o->result.fsmonitor_has_run_once` based upon value
in `o->src_index->fsmonitor_has_run_once` to prevent a second
fsmonitor query during the tree traversal and possibly getting
a skewed view of the working directory.

The checkout code has already talked to the fsmonitor and the
traversal is updating the index as it traverses, so there is
no need to query the fsmonitor.

Signed-off-by: Jeff Hostetler <redacted>
---
 unpack-trees.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/unpack-trees.c b/unpack-trees.c
index a7e1712d236..13e2e5de82c 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -1756,6 +1756,7 @@ int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options
 
 	o->result.fsmonitor_last_update =
 		xstrdup_or_null(o->src_index->fsmonitor_last_update);
+	o->result.fsmonitor_has_run_once = o->src_index->fsmonitor_has_run_once;
 
 	/*
 	 * Sparse checkout loop #1: set NEW_SKIP_WORKTREE on existing entries
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help