[PATCH v2 1/4] pack-objects: allow --filter without --stdout
From: John Cai via GitGitGadget <hidden>
Date: 2022-02-09 02:41:18
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: John Cai via GitGitGadget <hidden>
Date: 2022-02-09 02:41:18
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: John Cai <redacted> 9535ce7 taught pack-objects to use filtering, but added a requirement of the --stdout since a partial clone mechanism was not yet in place to handle missing objects. Since then, changes like 9e27beaa and others added support to dynamically fetch objects that were missing. Remove the --stdout requirement so that in the next commit, repack can pass --filter to pack-objects to omit certain objects from the packfile. Based-on-patch-by: Christian Couder [off-list ref] Signed-off-by: John Cai <redacted> --- builtin/pack-objects.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index ba2006f2212..2d1ecb18784 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c@@ -4075,8 +4075,6 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix) unpack_unreachable_expiration = 0; if (filter_options.choice) { - if (!pack_to_stdout) - die(_("cannot use --filter without --stdout")); if (stdin_packs) die(_("cannot use --filter with --stdin-packs")); }
--
gitgitgadget