Re: [PATCH v3 2/2] t/lib-read-tree-m-3way: indent with tabs
From: Shaoxuan Yuan <hidden>
Date: 2022-02-08 01:48:18
From: Shaoxuan Yuan <hidden>
Date: 2022-02-08 01:48:18
On Mon, Feb 7, 2022 at 7:54 PM Christian Couder [off-list ref] wrote:
On Sun, Feb 6, 2022 at 10:51 PM Shaoxuan Yuan [off-list ref] wrote:quoted
As Documentation/CodingGuidelines says, our shell scripts (including tests) are to use HT for indentation, but this scriptDocumentation/CodingGuidelines talks about "tabs" for indentation not "HT", so it would be more consistent to talk about "tabs" here too, or at least to say something like "are to use HT (horizontal tab) for indentation".
Agree, it should be phrased in a more consistent and understandable way.
quoted
uses 4-column indent with SP. Fix this.Same for "SP" here vs "space" in our doc. (Also note that `man ascii` talks about "HT" and "SPACE", not "SP".)
Agree. -- Thanks, Shaoxuan