Re: [PATCH 3/3] t5312: prepare for reftable

Han-Wen Nienhuys [off-list ref] writes:

On Tue, Feb 1, 2022 at 10:19 PM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

quoted

quoted

-test_expect_success 'pack-refs does not drop broken refs during deletion' '
+test_expect_success REFFILES  'pack-refs does not drop broken refs during deletion' '
      git update-ref -d refs/heads/other &&
      git rev-parse refs/heads/main >actual &&
      test_cmp expect actual

The setup for these is reffiles-specific, but it seems to me this is
something we'd really like to test with reftable rather than skipping it
entirely.

I.e. the scenario described in the "we create..." comment in this file
is something that might happen with reftable too, no?

That is tested in the 3 tests right above the ones I marked with
REFFILES ('pack-refs does not silently delete broken loose ref'). The
tests at the bottom check what happens if you have a missing SHA1 in a
packed-refs file. The reftable backend does not have a packed-refs, so
there is nothing to test.

Yup.  The patch posted looked good to me.

Thanks for writing and reviewing.