Re: [PATCH V2] patch-id: fix scan_hunk_header on diffs with 1 line of before/after

From
Junio C Hamano <hidden>
Date
2022-01-31 18:55:35
Jerry Zhang [off-list ref] writes:
Normally diffs will contain a hunk header of the format
"@@ -2,2 +2,15 @@ code". However in certain situations git can
omit the second comma separated value in either before or after
line counts in the case where there is only one line.
No need to resend, but this is specific enough (i.e. ",1" is
omitted) and "in certain situations" makes it needlessly fuzzy,
making readers wonder if there are any other cases.  Also, this is
not "git can omit".  The "unified context" format output from any
"diff" command share this special case.

Otherwise looking very good.

Thanks for a fix.  Will queue.
Thread (1 message) 1 message, 1 author, last reply 2022-01-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help