Re: [PATCH v3 2/3] sparse-checkout: custom tab completion
From: Lessley Dennington <hidden>
Date: 2022-01-18 17:59:22
From: Lessley Dennington <hidden>
Date: 2022-01-18 17:59:22
On 1/15/22 5:03 PM, Elijah Newren wrote:
On Sat, Jan 15, 2022 at 1:57 AM SZEDER Gábor [off-list ref] wrote:quoted
On Mon, Jan 10, 2022 at 06:59:51PM +0000, Lessley Dennington via GitGitGadget wrote:quoted
Subject: Re: [PATCH v3 2/3] sparse-checkout: custom tab completionNone of these patches touch sparse-checkout, but only the completion script and its tests. Therefore "completion:" would be a better matching area prefix.Thanks for the detailed feedback and guidance in your review. Very helpful. I'll omit quoting most of it here, but I do want to comment on the point about directories.
I second this - am planning to apply all feedback (with the exception of completing on both files and directories) in v4 of this series.